20xd6/simple_blog
2
0
Fork 1
Code Issues 10 Pull Requests 2 Projects Releases Wiki Activity

Fix issues #25 and #26 #27

Merged
20xd6 merged 2 commits from issue#26 into master 2022-08-09 14:15:37 -04:00
Conversation 0 Commits 2 Files Changed 1 +11 -14
20xd6 commented 2022-08-09 14:15:16 -04:00
Owner
Copy Link

This PR should reslove both issues #25 and #26 relating to how the author file is parsed.

Issue #25 is resolved by adding a check for the size of author before attempting to parse it and stopping if it is zero.

Issue #26 is resolved by removing the display of a No Byline <h2> banner if the author's byline.md file is not found.

This PR should reslove both issues #25 and #26 relating to how the `author` file is parsed. Issue #25 is resolved by adding a check for the size of `author` before attempting to parse it and stopping if it is zero. Issue #26 is resolved by removing the display of a `No Byline` `<h2>` banner if the author's `byline.md` file is not found.
20xd6 added this to the 1.0 Release milestone 2022-08-09 14:15:16 -04:00
20xd6 added the bug label 2022-08-09 14:15:16 -04:00
20xd6 added 2 commits 2022-08-09 14:15:16 -04:00
Add a size check before attempting to parse the author 5d7b4cc121 
The author file is now checked to insure it's non-zero before attempting
to parse it for the author who's byline will be displayed at the bottom
of the post.
Stop parsing if the author isn't found 470773721a
20xd6 merged commit 7734de9fa4 into master 2022-08-09 14:15:37 -04:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No Label bug
Milestone
No items
No Milestone 1.0 Release
Projects
Clear projects
No project
Assignees
Clear assignees
20xd6
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: 20xd6/simple_blog#27
Delete Branch "issue#26"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?