20xd6/simple_blog
2
0
Fork 1
Code Issues 10 Pull Requests 2 Projects Releases Wiki Activity

Missing tags.csv is not properly handled #9

New Issue
Closed
opened 2022-07-05 14:12:14 -04:00 by manfromhuh · 5 comments
manfromhuh commented 2022-07-05 14:12:14 -04:00
Contributor
Copy Link

The following two errors are generated if the tags.csv file is missing from /blog/by_tag/.

Warning: file(tags.csv): failed to open stream: No such file or directory in /path/to/blog/by_tag/index.php on line 37

Warning: array_map(): Argument #2 should be an array in /path/to/blog/by_tag/index.php on line 37
The following two errors are generated if the tags.csv file is missing from `/blog/by_tag/`. ``` Warning: file(tags.csv): failed to open stream: No such file or directory in /path/to/blog/by_tag/index.php on line 37 Warning: array_map(): Argument #2 should be an array in /path/to/blog/by_tag/index.php on line 37 ```
20xd6 added the
bug
 label 2022-07-05 14:52:50 -04:00
20xd6 added this to the 1.0 Release milestone 2022-07-05 14:52:55 -04:00
20xd6 commented 2022-07-26 13:11:17 -04:00
Owner
Copy Link

With PR #20 being merged into master this has been resolved.

With PR #20 being merged into master this has been resolved.
20xd6 closed this issue 2022-07-26 13:11:17 -04:00
manfromhuh commented 2022-07-27 13:14:42 -04:00
Author
Contributor
Copy Link

The tags.csv file will now be replaced but only if the permissions on the folder are changed. It will also create the file with permissions only for the webserver user. This should be explored to see if their's a way to allow the webserver to write to this directory and preserve the permissions so the "admin" user can still write to the tags.csv file. Otherwise it will create problems updating the tags.

The `tags.csv` file will now be replaced but only if the permissions on the folder are changed. It will also create the file with permissions only for the webserver user. This should be explored to see if their's a way to allow the webserver to write to this directory and preserve the permissions so the "admin" user can still write to the tags.csv file. Otherwise it will create problems updating the tags.
20xd6 referenced this issue from a commit 2022-07-27 20:17:34 -04:00
Resolve issue #9 (#21)
20xd6 commented 2022-07-27 20:23:21 -04:00
Owner
Copy Link

PR #21 resolves the issues mentioned for reopening this bug.

PR #21 resolves the issues mentioned for reopening this bug.
20xd6 closed this issue 2022-07-27 20:23:30 -04:00
20xd6 commented 2022-07-27 22:08:42 -04:00
Owner
Copy Link

PR #21 introduces a bug that prevents the tags.csv file from being read.

PR #21 introduces a bug that prevents the `tags.csv` file from being read.
20xd6 reopened this issue 2022-07-27 22:08:42 -04:00
20xd6 commented 2022-07-27 22:11:05 -04:00
Owner
Copy Link

Looks like it was testing the wrong variable for size. Pushing a fix to branch master and closing again.

Looks like it was testing the wrong variable for size. Pushing a fix to branch master and closing again.
20xd6 closed this issue 2022-07-27 22:11:08 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
question
More information is needed
wontfix
This won't be fixed
No Label
bug
Milestone
No items
No Milestone 1.0 Release
Projects
Clear projects
No project
Assignees
Clear assignees
20xd6
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: 20xd6/simple_blog#9
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?