From 2c6082a0a2828dc2083056b99696d6c4209e3869 Mon Sep 17 00:00:00 2001 From: md-yasir Date: Thu, 23 Oct 2025 22:50:12 +0530 Subject: [PATCH] Refactored stop conditions to be invariant by using while loop. --- src/main/java/org/json/Cookie.java | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/src/main/java/org/json/Cookie.java b/src/main/java/org/json/Cookie.java index 11cc97a..630136e 100644 --- a/src/main/java/org/json/Cookie.java +++ b/src/main/java/org/json/Cookie.java @@ -189,21 +189,30 @@ public class Cookie { * @return The unescaped string. */ public static String unescape(String string) { + int i = 0; int length = string.length(); StringBuilder sb = new StringBuilder(length); - for (int i = 0; i < length; ++i) { + + while (i < length) { char c = string.charAt(i); if (c == '+') { - c = ' '; + sb.append(' '); + i++; } else if (c == '%' && i + 2 < length) { int d = JSONTokener.dehexchar(string.charAt(i + 1)); int e = JSONTokener.dehexchar(string.charAt(i + 2)); + if (d >= 0 && e >= 0) { - c = (char)(d * 16 + e); - i += 2; + sb.append((char)(d * 16 + e)); + i += 3; + } else { + sb.append(c); + i++; } + } else { + sb.append(c); + i++; } - sb.append(c); } return sb.toString(); }