From e1eabc9c27f954ce8fe8032f12f92f51c0e7c9eb Mon Sep 17 00:00:00 2001 From: HariBabu t Date: Sat, 4 Mar 2023 23:08:32 +0800 Subject: [PATCH 1/2] JSONTokener implemented java.io.Closeable --- src/main/java/org/json/JSONTokener.java | 16 +++++++++------- .../java/org/json/junit/JSONTokenerTest.java | 12 ++++++++++++ 2 files changed, 21 insertions(+), 7 deletions(-) diff --git a/src/main/java/org/json/JSONTokener.java b/src/main/java/org/json/JSONTokener.java index 8c98c77..4b7d833 100644 --- a/src/main/java/org/json/JSONTokener.java +++ b/src/main/java/org/json/JSONTokener.java @@ -1,11 +1,6 @@ package org.json; -import java.io.BufferedReader; -import java.io.IOException; -import java.io.InputStream; -import java.io.InputStreamReader; -import java.io.Reader; -import java.io.StringReader; +import java.io.*; /* Public Domain. @@ -18,7 +13,7 @@ Public Domain. * @author JSON.org * @version 2014-05-03 */ -public class JSONTokener { +public class JSONTokener implements Closeable { /** current read character position on the current line. */ private long character; /** flag to indicate if the end of the input has been found. */ @@ -522,4 +517,11 @@ public class JSONTokener { return " at " + this.index + " [character " + this.character + " line " + this.line + "]"; } + + @Override + public void close() throws IOException { + if(reader!=null){ + reader.close(); + } + } } diff --git a/src/test/java/org/json/junit/JSONTokenerTest.java b/src/test/java/org/json/junit/JSONTokenerTest.java index da716b8..59ca6d8 100644 --- a/src/test/java/org/json/junit/JSONTokenerTest.java +++ b/src/test/java/org/json/junit/JSONTokenerTest.java @@ -313,4 +313,16 @@ public class JSONTokenerTest { assertEquals(0, t2.next()); assertFalse(t2.more()); } + + @Test + public void testAutoClose(){ + Reader reader = new StringReader("some test string"); + try { + JSONTokener tokener = new JSONTokener(reader); + tokener.close(); + tokener.next(); + } catch (Exception exception){ + assertEquals("Stream closed", exception.getMessage()); + } + } } From 7eca507d13c741dcf0fb468565439dcad937e794 Mon Sep 17 00:00:00 2001 From: HariBabu t Date: Tue, 7 Mar 2023 13:58:30 +0800 Subject: [PATCH 2/2] Removed overriding closable interface. --- src/main/java/org/json/JSONTokener.java | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/main/java/org/json/JSONTokener.java b/src/main/java/org/json/JSONTokener.java index 4b7d833..c180580 100644 --- a/src/main/java/org/json/JSONTokener.java +++ b/src/main/java/org/json/JSONTokener.java @@ -13,7 +13,7 @@ Public Domain. * @author JSON.org * @version 2014-05-03 */ -public class JSONTokener implements Closeable { +public class JSONTokener { /** current read character position on the current line. */ private long character; /** flag to indicate if the end of the input has been found. */ @@ -518,7 +518,6 @@ public class JSONTokener implements Closeable { this.line + "]"; } - @Override public void close() throws IOException { if(reader!=null){ reader.close();