Backups/Mango
1
0
Fork 0
mirror of https://github.com/hkalexling/Mango.git synced 2025-08-03 03:15:31 -04:00
Code Issues Projects Releases Wiki Activity

Fix caching policy

Browse Source 
Before rendering it, the Mango reader should check the E-Tag of page
or it renders wrong image when an image file is moved/removed/reordered
This commit is contained in:
Leeingnyo 2022-05-15 15:31:33 +09:00
parent 3b3a0738e8
commit 137e84dfb6
1 changed files with 17 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/routes/api.cr
View File

@ -142,8 +142,13 @@ struct APIRouter
env.response.status_code = 304 env.response.status_code = 304
"" ""
else else
if entry.is_a? DirectoryEntry
cache_control = "no-cache, max-age=86400"
else
cache_control = "public, max-age=86400"
end
env.response.headers["ETag"] = e_tag env.response.headers["ETag"] = e_tag
env.response.headers["Cache-Control"] = "public, max-age=86400" env.response.headers["Cache-Control"] = cache_control
send_img env, img send_img env, img
end end
rescue e rescue e
@ -1138,15 +1143,24 @@ struct APIRouter
entry = title.get_entry eid entry = title.get_entry eid
raise "Entry ID `#{eid}` of `#{title.title}` not found" if entry.nil? raise "Entry ID `#{eid}` of `#{title.title}` not found" if entry.nil?
file_hash = Digest::SHA1.hexdigest (entry.path + entry.mtime.to_s) if entry.is_a? DirectoryEntry
file_hash = Digest::SHA1.hexdigest (entry.path + entry.mtime.to_s + entry.size)
else
file_hash = Digest::SHA1.hexdigest (entry.path + entry.mtime.to_s)
end
e_tag = "W/#{file_hash}" e_tag = "W/#{file_hash}"
if e_tag == prev_e_tag if e_tag == prev_e_tag
env.response.status_code = 304 env.response.status_code = 304
send_text env, "" send_text env, ""
else else
sizes = entry.page_dimensions sizes = entry.page_dimensions
if entry.is_a? DirectoryEntry
cache_control = "no-cache, max-age=86400"
else
cache_control = "public, max-age=86400"
end
env.response.headers["ETag"] = e_tag env.response.headers["ETag"] = e_tag
env.response.headers["Cache-Control"] = "public, max-age=86400" env.response.headers["Cache-Control"] = cache_control
send_json env, { send_json env, {
"success" => true, "success" => true,
"dimensions" => sizes, "dimensions" => sizes,