Better state management in spec and add some tests for MangaDex::Queue

spec/storage_spec.cr

@@ -1,66 +1,91 @@
 require "./spec_helper"
 
 describe Storage do
-	temp_config = File.tempfile "mango-test-config"
-	temp_db = File.tempfile "mango-test-db"
-	config = Config.load temp_config.path
-	user_token = nil
-	admin_token = nil
-
 	it "creates DB at given path" do
-		storage = Storage.new temp_db.path, MLogger.new config
-		File.exists?(temp_db.path).should be_true
+		with_storage do |storage, path|
+			File.exists?(path).should be_true
+		end
 	end
+
 	it "deletes user" do
-		storage = Storage.new temp_db.path, MLogger.new config
-		storage.delete_user "admin"
+		with_storage do |storage|
+			storage.delete_user "admin"
+		end
 	end
+
 	it "creates new user" do
-		storage = Storage.new temp_db.path, MLogger.new config
-		storage.new_user "user", "123456", false
-		storage.new_user "admin", "123456", true
-	end
-	it "verifies username/password combination" do
-		storage = Storage.new temp_db.path, MLogger.new config
-		user_token = storage.verify_user "user", "123456"
-		admin_token = storage.verify_user "admin", "123456"
-		user_token.should_not be_nil
-		admin_token.should_not be_nil
-	end
-	it "rejects duplicate username" do
-		storage = Storage.new temp_db.path, MLogger.new config
-		expect_raises SQLite3::Exception,
-			"UNIQUE constraint failed: users.username" do
+		with_storage do |storage|
+			storage.new_user "user", "123456", false
 			storage.new_user "admin", "123456", true
 		end
 	end
-	it "verifies token" do
-		storage = Storage.new temp_db.path, MLogger.new config
-		token = storage.verify_token user_token
-		token.should eq "user"
-	end
-	it "verfies admin token" do
-		storage = Storage.new temp_db.path, MLogger.new config
-		storage.verify_admin(admin_token).should be_true
-	end
-	it "rejects non-admin token" do
-		storage = Storage.new temp_db.path, MLogger.new config
-		storage.verify_admin(user_token).should be_false
-	end
-	it "updates user" do
-		storage = Storage.new temp_db.path, MLogger.new config
-		storage.update_user "admin", "admin", "654321", true
-		token = storage.verify_user "admin", "654321"
-		token.should eq admin_token
-	end
-	it "logs user out" do
-		storage = Storage.new temp_db.path, MLogger.new config
-		storage.logout user_token
-		storage.logout admin_token
-		storage.verify_token(user_token).should be_nil
-		storage.verify_token(admin_token).should be_nil
+
+	it "verifies username/password combination" do
+		with_storage do |storage|
+			user_token = storage.verify_user "user", "123456"
+			admin_token = storage.verify_user "admin", "123456"
+			user_token.should_not be_nil
+			admin_token.should_not be_nil
+			State.set "user_token", user_token
+			State.set "admin_token", admin_token
+		end
 	end
 
-	temp_config.delete
-	temp_db.delete
+	it "rejects duplicate username" do
+		with_storage do |storage|
+			expect_raises SQLite3::Exception,
+				"UNIQUE constraint failed: users.username" do
+				storage.new_user "admin", "123456", true
+			end
+		end
+	end
+
+	it "verifies token" do
+		with_storage do |storage|
+			user_token = State.get! "user_token"
+			user = storage.verify_token user_token
+			user.should eq "user"
+		end
+	end
+
+	it "verfies admin token" do
+		with_storage do |storage|
+			admin_token = State.get! "admin_token"
+			storage.verify_admin(admin_token).should be_true
+		end
+	end
+
+	it "rejects non-admin token" do
+		with_storage do |storage|
+			user_token = State.get! "user_token"
+			storage.verify_admin(user_token).should be_false
+		end
+	end
+
+	it "updates user" do
+		with_storage do |storage|
+			storage.update_user "admin", "admin", "654321", true
+			token = storage.verify_user "admin", "654321"
+			admin_token = State.get! "admin_token"
+			token.should eq admin_token
+		end
+	end
+
+	it "logs user out" do
+		with_storage do |storage|
+			user_token = State.get! "user_token"
+			admin_token = State.get! "admin_token"
+			storage.logout user_token
+			storage.logout admin_token
+			storage.verify_token(user_token).should be_nil
+			storage.verify_token(admin_token).should be_nil
+		end
+	end
+
+	it "cleans up" do
+		State.reset
+		with_storage do
+			true
+		end
+	end
 end