From 22a660aabfaacabc403a10496f41c69d1aeb5bf6 Mon Sep 17 00:00:00 2001
From: Alex Ling <hkalexling@gmail.com>
Date: Wed, 29 Jul 2020 10:07:10 +0000
Subject: [PATCH] Fix 500 for empty plugins

---
 src/routes/main.cr                 |  3 ++-
 src/views/plugin-download.html.ecr | 14 ++++++++------
 2 files changed, 10 insertions(+), 7 deletions(-)

diff --git a/src/routes/main.cr b/src/routes/main.cr
index 5396604..5801297 100644
--- a/src/routes/main.cr
+++ b/src/routes/main.cr
@@ -82,10 +82,11 @@ class MainRouter < Router
       begin
         id = env.params.query["plugin"]?
         plugins = Plugin.list
+        plugin = nil
 
         if id
           plugin = Plugin.new id
-        else
+        elsif !plugins.empty?
           plugin = Plugin.new plugins[0][:id]
         end
 
diff --git a/src/views/plugin-download.html.ecr b/src/views/plugin-download.html.ecr
index 29b3065..68eb156 100644
--- a/src/views/plugin-download.html.ecr
+++ b/src/views/plugin-download.html.ecr
@@ -1,6 +1,6 @@
 <% if plugins.empty? %>
   <div class="uk-container uk-text-center">
-    <h2>No Plugins found</h2>
+    <h2>No Plugins Found</h2>
     <p>We could't find any plugins in the directory <code><%= Config.current.plugin_path %></code>.</p>
     <p>You can download official plugins from the <a href="https://github.com/hkalexling/mango-plugins">Mango plugins repository</a>.</p>
   </div>
@@ -13,7 +13,7 @@
       <div class="uk-margin">
         <label class="uk-form-label" for="search-input">&nbsp;</label>
         <div class="uk-form-controls">
-          <input id="search-input" class="uk-input" type="text" placeholder="<%= plugin.info.placeholder %>">
+          <input id="search-input" class="uk-input" type="text" placeholder="<%= plugin.not_nil!.info.placeholder %>">
         </div>
       </div>
     </div>
@@ -40,7 +40,7 @@
   </div>
 
   <dl class="uk-description-list" id="toggle" hidden>
-    <% plugin.info.each do |k, v| %>
+    <% plugin.not_nil!.info.each do |k, v| %>
       <dt><%= k %></dt>
       <dd><%= v.to_s %></dd>
     <% end %>
@@ -63,9 +63,11 @@
 
 
 <% content_for "script" do %>
-  <script>
-    var pid = "<%= plugin.info.id %>";
-  </script>
+  <% if plugin %>
+    <script>
+      var pid = "<%= plugin.not_nil!.info.id %>";
+    </script>
+  <% end %>
   <script src="https://cdnjs.cloudflare.com/ajax/libs/jqueryui/1.12.1/jquery-ui.min.js"></script>
   <script src="https://cdnjs.cloudflare.com/ajax/libs/jquery.tablesorter/2.31.3/js/jquery.tablesorter.combined.min.js"></script>
   <script src="<%= base_url %>js/alert.js"></script>