From bac7be51633b6b89524f2de2cf60c71b60fcb449 Mon Sep 17 00:00:00 2001 From: Alex Ling Date: Tue, 9 Jun 2020 09:25:20 +0000 Subject: [PATCH 1/2] Escape slash in filename when downloading (#62) --- src/rename.cr | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/rename.cr b/src/rename.cr index 3aefcef..cd6af7b 100644 --- a/src/rename.cr +++ b/src/rename.cr @@ -135,7 +135,9 @@ module Rename else e.render hash end - end.join.strip + end.join + .strip + .gsub("/", "_") end end end From 3d352ed062b3645604308b552975eb10447ca43d Mon Sep 17 00:00:00 2001 From: Alex Ling Date: Tue, 9 Jun 2020 09:28:37 +0000 Subject: [PATCH 2/2] Add test for slash escaping --- spec/rename_spec.cr | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/spec/rename_spec.cr b/spec/rename_spec.cr index 6108974..c830581 100644 --- a/spec/rename_spec.cr +++ b/spec/rename_spec.cr @@ -68,4 +68,9 @@ describe Rule do .should eq "Ch. CH ID testing" rule.render({} of String => String).should eq "testing" end + + it "escapes slash" do + rule = Rule.new "{id}" + rule.render({"id" => "/hello/world"}).should eq "_hello_world" + end end