From def64d9f98be18e2baf091360b0b4c8df53aef81 Mon Sep 17 00:00:00 2001
From: Alex Ling <hkalexling@gmail.com>
Date: Tue, 26 Jan 2021 10:55:50 +0000
Subject: [PATCH] Rename interesting files to supported files

---
 spec/util_spec.cr     | 17 +++++++----------
 src/library/title.cr  |  2 +-
 src/util/signature.cr |  2 +-
 src/util/util.cr      | 14 +++++++-------
 4 files changed, 16 insertions(+), 19 deletions(-)

diff --git a/spec/util_spec.cr b/spec/util_spec.cr
index 5401eb1..3ee4aac 100644
--- a/spec/util_spec.cr
+++ b/spec/util_spec.cr
@@ -35,23 +35,20 @@ describe "compare_numerically" do
   end
 end
 
-describe "is_interesting_file" do
-  it "returns true when filename has interesting file extension" do
+describe "is_supported_file" do
+  it "returns true when the filename has a supported extension" do
     filename = "manga.cbz"
-    result = is_interesting_file filename
-    result.should eq true
+    is_supported_file(filename).should eq true
   end
 
-  it "returns false if file extension is not interesting" do
+  it "returns true when the filename does not have a supported extension" do
     filename = "info.json"
-    result = is_interesting_file filename
-    result.should eq false
+    is_supported_file(filename).should eq false
   end
 
-  it "returns true when fileext has uppercase" do
+  it "is case insensitive" do
     filename = "manga.ZiP"
-    result = is_interesting_file filename
-    result.should eq true
+    is_supported_file(filename).should eq true
   end
 end
 
diff --git a/src/library/title.cr b/src/library/title.cr
index 3f3926a..4c439e7 100644
--- a/src/library/title.cr
+++ b/src/library/title.cr
@@ -36,7 +36,7 @@ class Title
         @title_ids << title.id
         next
       end
-      if is_interesting_file path
+      if is_supported_file path
         entry = Entry.new path, self
         @entries << entry if entry.pages > 0 || entry.err_msg
       end
diff --git a/src/util/signature.cr b/src/util/signature.cr
index 7dc738b..05eb62d 100644
--- a/src/util/signature.cr
+++ b/src/util/signature.cr
@@ -13,7 +13,7 @@ class File
   #   ensures that moving (unless to another device) and renaming the file
   #   preserves the signature, while copying or editing the file changes it.
   def self.signature(filename) : UInt64
-    return 0u64 unless is_interesting_file filename
+    return 0u64 unless is_supported_file filename
     info = File.info filename
     signatures = [
       info.inode,
diff --git a/src/util/util.cr b/src/util/util.cr
index 17fe105..873a226 100644
--- a/src/util/util.cr
+++ b/src/util/util.cr
@@ -1,8 +1,8 @@
-IMGS_PER_PAGE             = 5
-ENTRIES_IN_HOME_SECTIONS  = 8
-UPLOAD_URL_PREFIX         = "/uploads"
-STATIC_DIRS               = ["/css", "/js", "/img", "/favicon.ico"]
-INTERESTING_FILE_EXTNAMES = [".zip", ".cbz", ".rar", ".cbr"]
+IMGS_PER_PAGE            = 5
+ENTRIES_IN_HOME_SECTIONS = 8
+UPLOAD_URL_PREFIX        = "/uploads"
+STATIC_DIRS              = ["/css", "/js", "/img", "/favicon.ico"]
+SUPPORTED_FILE_EXTNAMES  = [".zip", ".cbz", ".rar", ".cbr"]
 
 def random_str
   UUID.random.to_s.gsub "-", ""
@@ -32,8 +32,8 @@ def register_mime_types
   end
 end
 
-def is_interesting_file(path)
-  INTERESTING_FILE_EXTNAMES.includes? (File.extname path).downcase
+def is_supported_file(path)
+  SUPPORTED_FILE_EXTNAMES.includes? File.extname(path).downcase
 end
 
 struct Int