diff --git a/common/common-io/src/main/java/com/twelvemonkeys/xml/DOMSerializer.java b/common/common-io/src/main/java/com/twelvemonkeys/xml/DOMSerializer.java index e2975901..156630e9 100755 --- a/common/common-io/src/main/java/com/twelvemonkeys/xml/DOMSerializer.java +++ b/common/common-io/src/main/java/com/twelvemonkeys/xml/DOMSerializer.java @@ -29,6 +29,9 @@ package com.twelvemonkeys.xml; +import java.io.OutputStream; +import java.io.Writer; + import org.w3c.dom.DOMConfiguration; import org.w3c.dom.DOMImplementationList; import org.w3c.dom.Document; @@ -38,9 +41,6 @@ import org.w3c.dom.ls.DOMImplementationLS; import org.w3c.dom.ls.LSOutput; import org.w3c.dom.ls.LSSerializer; -import java.io.OutputStream; -import java.io.Writer; - /** * {@code DOMImplementationLS} backed implementation. * @@ -88,17 +88,6 @@ public final class DOMSerializer { output.setCharacterStream(pStream); } - /* - // TODO: Is it useful? - public void setNewLine(final String pNewLine) { - serializer.setNewLine(pNewLine); - } - - public String getNewLine() { - return serializer.getNewLine(); - } - */ - /** * Specifies wether the serializer should use indentation and optimize for * readability. @@ -169,13 +158,7 @@ public final class DOMSerializer { try { return DOMImplementationRegistry.newInstance(); } - catch (ClassNotFoundException e) { - throw new IllegalStateException(e); - } - catch (InstantiationException e) { - throw new IllegalStateException(e); - } - catch (IllegalAccessException e) { + catch (ClassNotFoundException | InstantiationException | IllegalAccessException e) { throw new IllegalStateException(e); } } diff --git a/common/common-io/src/main/java/com/twelvemonkeys/xml/XMLSerializer.java b/common/common-io/src/main/java/com/twelvemonkeys/xml/XMLSerializer.java index 50ef4673..bc226bdf 100644 --- a/common/common-io/src/main/java/com/twelvemonkeys/xml/XMLSerializer.java +++ b/common/common-io/src/main/java/com/twelvemonkeys/xml/XMLSerializer.java @@ -30,16 +30,23 @@ package com.twelvemonkeys.xml; -import com.twelvemonkeys.lang.StringUtil; -import org.w3c.dom.*; -import org.xml.sax.SAXException; +import java.io.ByteArrayInputStream; +import java.io.ByteArrayOutputStream; +import java.io.IOException; +import java.io.OutputStream; +import java.io.OutputStreamWriter; +import java.io.PrintWriter; +import java.nio.charset.Charset; +import java.util.Date; import javax.xml.parsers.DocumentBuilder; import javax.xml.parsers.DocumentBuilderFactory; import javax.xml.parsers.ParserConfigurationException; -import java.io.*; -import java.nio.charset.Charset; -import java.util.Date; + +import org.w3c.dom.*; +import org.xml.sax.SAXException; + +import com.twelvemonkeys.lang.StringUtil; /** * XMLSerializer @@ -290,7 +297,7 @@ public class XMLSerializer { } private static int appendAndEscape(final String pString, int pStart, final int pEnd, final StringBuilder pBuilder, final String pEntity) { - pBuilder.append(pString.substring(pStart, pEnd)); + pBuilder.append(pString, pStart, pEnd); pBuilder.append(pEntity); return pEnd + 1; } @@ -527,8 +534,7 @@ public class XMLSerializer { builder = factory.newDocumentBuilder(); } catch (ParserConfigurationException e) { - //noinspection ThrowableInstanceNeverThrown BOGUS - throw (IOException) new IOException(e.getMessage()).initCause(e); + throw new IOException(e); } DOMImplementation dom = builder.getDOMImplementation();