From 821c20c09a7248368b901e5eff6cb15b8cd64d59 Mon Sep 17 00:00:00 2001 From: Harald Kuhr Date: Fri, 5 Jun 2015 10:58:54 +0200 Subject: [PATCH] TMI-136: Clean-up and added TODOs. --- .../twelvemonkeys/imageio/metadata/iptc/IPTCWriter.java | 8 ++++++++ .../imageio/metadata/iptc/IPTCWriterTest.java | 1 - 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/imageio/imageio-metadata/src/main/java/com/twelvemonkeys/imageio/metadata/iptc/IPTCWriter.java b/imageio/imageio-metadata/src/main/java/com/twelvemonkeys/imageio/metadata/iptc/IPTCWriter.java index 88a1c6b5..11904a7f 100644 --- a/imageio/imageio-metadata/src/main/java/com/twelvemonkeys/imageio/metadata/iptc/IPTCWriter.java +++ b/imageio/imageio-metadata/src/main/java/com/twelvemonkeys/imageio/metadata/iptc/IPTCWriter.java @@ -23,6 +23,9 @@ public final class IPTCWriter extends MetadataWriter { notNull(directory, "directory"); notNull(stream, "stream"); + // TODO: Make sure we always write application record version (2.00) + // TODO: Write encoding UTF8? + for (Entry entry : directory) { int tag = (Integer) entry.getIdentifier(); Object value = entry.getValue(); @@ -52,6 +55,11 @@ public final class IPTCWriter extends MetadataWriter { stream.writeShort(data.length); stream.write(data); } + else if (value instanceof byte[]) { + byte[] data = (byte[]) value; + stream.writeShort(data.length); + stream.write(data); + } else if (value instanceof Integer) { // TODO: Need to know types from tag stream.writeShort(2); diff --git a/imageio/imageio-metadata/src/test/java/com/twelvemonkeys/imageio/metadata/iptc/IPTCWriterTest.java b/imageio/imageio-metadata/src/test/java/com/twelvemonkeys/imageio/metadata/iptc/IPTCWriterTest.java index dd620eae..e5f277db 100644 --- a/imageio/imageio-metadata/src/test/java/com/twelvemonkeys/imageio/metadata/iptc/IPTCWriterTest.java +++ b/imageio/imageio-metadata/src/test/java/com/twelvemonkeys/imageio/metadata/iptc/IPTCWriterTest.java @@ -66,7 +66,6 @@ public class IPTCWriterTest extends MetadataWriterAbstractTest { stream.close(); Directory written = createReader().read(new ByteArrayImageInputStream(bytes.toByteArray())); - System.err.println("written: " + written); assertEquals(iptc, written); } } \ No newline at end of file