From 99c5fea0056dccf753529afa1f4c488eeaa48029 Mon Sep 17 00:00:00 2001
From: Harald Kuhr <harald.kuhr@gmail.com>
Date: Fri, 21 Aug 2015 15:24:49 +0200
Subject: [PATCH] TMI #166 Remove printStackTrace() from EXIFReader

---
 .../imageio/metadata/exif/EXIFReader.java           | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/imageio/imageio-metadata/src/main/java/com/twelvemonkeys/imageio/metadata/exif/EXIFReader.java b/imageio/imageio-metadata/src/main/java/com/twelvemonkeys/imageio/metadata/exif/EXIFReader.java
index 40ce112f..284e45f0 100644
--- a/imageio/imageio-metadata/src/main/java/com/twelvemonkeys/imageio/metadata/exif/EXIFReader.java
+++ b/imageio/imageio-metadata/src/main/java/com/twelvemonkeys/imageio/metadata/exif/EXIFReader.java
@@ -89,8 +89,8 @@ public final class EXIFReader extends MetadataReader {
 
     // TODO: Consider re-writing so that the linked IFD parsing is done externally to the method
     protected Directory readDirectory(final ImageInputStream pInput, final long pOffset, final boolean readLinked) throws IOException {
-        List<IFD> ifds = new ArrayList<IFD>();
-        List<Entry> entries = new ArrayList<Entry>();
+        List<IFD> ifds = new ArrayList<>();
+        List<Entry> entries = new ArrayList<>();
 
         pInput.seek(pOffset);
         long nextOffset = -1;
@@ -156,7 +156,7 @@ public final class EXIFReader extends MetadataReader {
                 try {
                     if (KNOWN_IFDS.contains(tagId)) {
                         long[] pointerOffsets = getPointerOffsets(entry);
-                        List<IFD> subIFDs = new ArrayList<IFD>(pointerOffsets.length);
+                        List<IFD> subIFDs = new ArrayList<>(pointerOffsets.length);
 
                         for (long pointerOffset : pointerOffsets) {
                             CompoundDirectory subDirectory = (CompoundDirectory) readDirectory(input, pointerOffset, false);
@@ -177,8 +177,11 @@ public final class EXIFReader extends MetadataReader {
                     }
                 }
                 catch (IIOException e) {
-                    // TODO: Issue warning without crashing...?
-                    e.printStackTrace();
+                    if (DEBUG) {
+                        // TODO: Issue warning without crashing...?
+                        System.err.println("Error parsing sub-IFD: " + tagId);
+                        e.printStackTrace();
+                    }
                 }
             }
         }