mirror of
				https://gitlab.com/ytdl-org/youtube-dl.git
				synced 2025-11-04 07:47:08 -05:00 
			
		
		
		
	[vimeo] Convert to new subtitles system
Removed some tests, the behaviour should be checked in a test for the YoutubeDL class
This commit is contained in:
		@@ -28,7 +28,7 @@
 | 
			
		||||
    "retries": 10, 
 | 
			
		||||
    "simulate": false, 
 | 
			
		||||
    "subtitleslang": null, 
 | 
			
		||||
    "subtitlesformat": "srt",
 | 
			
		||||
    "subtitlesformat": "best",
 | 
			
		||||
    "test": true, 
 | 
			
		||||
    "updatetime": true, 
 | 
			
		||||
    "usenetrc": false, 
 | 
			
		||||
 
 | 
			
		||||
@@ -240,10 +240,6 @@ class TestVimeoSubtitles(BaseTestSubtitles):
 | 
			
		||||
    url = 'http://vimeo.com/76979871'
 | 
			
		||||
    IE = VimeoIE
 | 
			
		||||
 | 
			
		||||
    def test_no_writesubtitles(self):
 | 
			
		||||
        subtitles = self.getSubtitles()
 | 
			
		||||
        self.assertEqual(subtitles, None)
 | 
			
		||||
 | 
			
		||||
    def test_subtitles(self):
 | 
			
		||||
        self.DL.params['writesubtitles'] = True
 | 
			
		||||
        subtitles = self.getSubtitles()
 | 
			
		||||
@@ -261,19 +257,6 @@ class TestVimeoSubtitles(BaseTestSubtitles):
 | 
			
		||||
        subtitles = self.getSubtitles()
 | 
			
		||||
        self.assertEqual(set(subtitles.keys()), set(['de', 'en', 'es', 'fr']))
 | 
			
		||||
 | 
			
		||||
    def test_list_subtitles(self):
 | 
			
		||||
        self.DL.expect_warning('Automatic Captions not supported by this server')
 | 
			
		||||
        self.DL.params['listsubtitles'] = True
 | 
			
		||||
        info_dict = self.getInfoDict()
 | 
			
		||||
        self.assertEqual(info_dict, None)
 | 
			
		||||
 | 
			
		||||
    def test_automatic_captions(self):
 | 
			
		||||
        self.DL.expect_warning('Automatic Captions not supported by this server')
 | 
			
		||||
        self.DL.params['writeautomaticsub'] = True
 | 
			
		||||
        self.DL.params['subtitleslang'] = ['en']
 | 
			
		||||
        subtitles = self.getSubtitles()
 | 
			
		||||
        self.assertTrue(len(subtitles.keys()) == 0)
 | 
			
		||||
 | 
			
		||||
    def test_nosubtitles(self):
 | 
			
		||||
        self.DL.expect_warning('video doesn\'t have subtitles')
 | 
			
		||||
        self.url = 'http://vimeo.com/56015672'
 | 
			
		||||
 
 | 
			
		||||
@@ -6,7 +6,6 @@ import re
 | 
			
		||||
import itertools
 | 
			
		||||
 | 
			
		||||
from .common import InfoExtractor
 | 
			
		||||
from .subtitles import SubtitlesInfoExtractor
 | 
			
		||||
from ..compat import (
 | 
			
		||||
    compat_HTTPError,
 | 
			
		||||
    compat_urllib_parse,
 | 
			
		||||
@@ -51,7 +50,7 @@ class VimeoBaseInfoExtractor(InfoExtractor):
 | 
			
		||||
        self._download_webpage(login_request, None, False, 'Wrong login info')
 | 
			
		||||
 | 
			
		||||
 | 
			
		||||
class VimeoIE(VimeoBaseInfoExtractor, SubtitlesInfoExtractor):
 | 
			
		||||
class VimeoIE(VimeoBaseInfoExtractor):
 | 
			
		||||
    """Information extractor for vimeo.com."""
 | 
			
		||||
 | 
			
		||||
    # _VALID_URL matches Vimeo URLs
 | 
			
		||||
@@ -368,12 +367,10 @@ class VimeoIE(VimeoBaseInfoExtractor, SubtitlesInfoExtractor):
 | 
			
		||||
        text_tracks = config['request'].get('text_tracks')
 | 
			
		||||
        if text_tracks:
 | 
			
		||||
            for tt in text_tracks:
 | 
			
		||||
                subtitles[tt['lang']] = 'http://vimeo.com' + tt['url']
 | 
			
		||||
 | 
			
		||||
        video_subtitles = self.extract_subtitles(video_id, subtitles)
 | 
			
		||||
        if self._downloader.params.get('listsubtitles', False):
 | 
			
		||||
            self._list_available_subtitles(video_id, subtitles)
 | 
			
		||||
            return
 | 
			
		||||
                subtitles[tt['lang']] = [{
 | 
			
		||||
                    'ext': 'vtt',
 | 
			
		||||
                    'url': 'http://vimeo.com' + tt['url'],
 | 
			
		||||
                }]
 | 
			
		||||
 | 
			
		||||
        return {
 | 
			
		||||
            'id': video_id,
 | 
			
		||||
@@ -389,7 +386,7 @@ class VimeoIE(VimeoBaseInfoExtractor, SubtitlesInfoExtractor):
 | 
			
		||||
            'view_count': view_count,
 | 
			
		||||
            'like_count': like_count,
 | 
			
		||||
            'comment_count': comment_count,
 | 
			
		||||
            'subtitles': video_subtitles,
 | 
			
		||||
            'subtitles': subtitles,
 | 
			
		||||
        }
 | 
			
		||||
 | 
			
		||||
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user