Backups/TwelveMonkeys
2
0
Fork 0
mirror of https://github.com/haraldk/TwelveMonkeys.git synced 2025-08-05 12:35:29 -04:00
Code Issues Projects Releases Wiki Activity

TMI-136: Clean-up and added TODOs.

Browse Source
This commit is contained in:
Harald Kuhr 2015-06-05 10:58:54 +02:00
parent 194f34894f
commit 821c20c09a
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
imageio/imageio-metadata/src/main/java/com/twelvemonkeys/imageio/metadata/iptc/IPTCWriter.java
View File

@ -23,6 +23,9 @@ public final class IPTCWriter extends MetadataWriter {
notNull(directory, "directory"); notNull(directory, "directory");
notNull(stream, "stream"); notNull(stream, "stream");
// TODO: Make sure we always write application record version (2.00)
// TODO: Write encoding UTF8?
for (Entry entry : directory) { for (Entry entry : directory) {
int tag = (Integer) entry.getIdentifier(); int tag = (Integer) entry.getIdentifier();
Object value = entry.getValue(); Object value = entry.getValue();
@ -52,6 +55,11 @@ public final class IPTCWriter extends MetadataWriter {
stream.writeShort(data.length); stream.writeShort(data.length);
stream.write(data); stream.write(data);
} }
else if (value instanceof byte[]) {
byte[] data = (byte[]) value;
stream.writeShort(data.length);
stream.write(data);
}
else if (value instanceof Integer) { else if (value instanceof Integer) {
// TODO: Need to know types from tag // TODO: Need to know types from tag
stream.writeShort(2); stream.writeShort(2);

1
imageio/imageio-metadata/src/test/java/com/twelvemonkeys/imageio/metadata/iptc/IPTCWriterTest.java
View File

@ -66,7 +66,6 @@ public class IPTCWriterTest extends MetadataWriterAbstractTest {
stream.close(); stream.close();
Directory written = createReader().read(new ByteArrayImageInputStream(bytes.toByteArray())); Directory written = createReader().read(new ByteArrayImageInputStream(bytes.toByteArray()));
System.err.println("written: " + written);
assertEquals(iptc, written); assertEquals(iptc, written);
} }
} }