mirror of
				https://gitlab.com/ytdl-org/youtube-dl.git
				synced 2025-11-03 23:17:07 -05:00 
			
		
		
		
	[__init__] Fix lost xattr if --embed-thumbnail used
Reported at https://github.com/rg3/youtube-dl/issues/9054#issuecomment-250451823
This commit is contained in:
		@@ -1,6 +1,7 @@
 | 
			
		||||
version <unreleased>
 | 
			
		||||
 | 
			
		||||
Core
 | 
			
		||||
* Fix possibly lost extended attributes
 | 
			
		||||
+ Support pyxattr as well as python-xattr for --xattrs and
 | 
			
		||||
  --xattr-set-filesize (#9054)
 | 
			
		||||
 | 
			
		||||
 
 | 
			
		||||
@@ -266,8 +266,6 @@ def _real_main(argv=None):
 | 
			
		||||
        postprocessors.append({
 | 
			
		||||
            'key': 'FFmpegEmbedSubtitle',
 | 
			
		||||
        })
 | 
			
		||||
    if opts.xattrs:
 | 
			
		||||
        postprocessors.append({'key': 'XAttrMetadata'})
 | 
			
		||||
    if opts.embedthumbnail:
 | 
			
		||||
        already_have_thumbnail = opts.writethumbnail or opts.write_all_thumbnails
 | 
			
		||||
        postprocessors.append({
 | 
			
		||||
@@ -276,6 +274,10 @@ def _real_main(argv=None):
 | 
			
		||||
        })
 | 
			
		||||
        if not already_have_thumbnail:
 | 
			
		||||
            opts.writethumbnail = True
 | 
			
		||||
    # XAttrMetadataPP should be run after post-processors that may change file
 | 
			
		||||
    # contents
 | 
			
		||||
    if opts.xattrs:
 | 
			
		||||
        postprocessors.append({'key': 'XAttrMetadata'})
 | 
			
		||||
    # Please keep ExecAfterDownload towards the bottom as it allows the user to modify the final file in any way.
 | 
			
		||||
    # So if the user is able to remove the file before your postprocessor runs it might cause a few problems.
 | 
			
		||||
    if opts.exec_cmd:
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user