mirror of
				https://gitlab.com/ytdl-org/youtube-dl.git
				synced 2025-11-03 21:07:06 -05:00 
			
		
		
		
	[YoutubeDL] Fix bug in the detection of formats that don't contain video (fixes #4150)
If the format requested was not available, we called the method '.get' in None.
This commit is contained in:
		@@ -837,14 +837,14 @@ class YoutubeDL(object):
 | 
			
		||||
                        format_1, format_2 = rf.split('+')
 | 
			
		||||
                        formats_info = (self.select_format(format_1, formats),
 | 
			
		||||
                            self.select_format(format_2, formats))
 | 
			
		||||
                        # The first format must contain the video and the
 | 
			
		||||
                        # second the audio
 | 
			
		||||
                        if formats_info[0].get('vcodec') == 'none':
 | 
			
		||||
                            self.report_error('The first format must contain '
 | 
			
		||||
                                'the video, try using "-f %s+%s"' %
 | 
			
		||||
                                (format_2, format_1))
 | 
			
		||||
                            return
 | 
			
		||||
                        if all(formats_info):
 | 
			
		||||
                            # The first format must contain the video and the
 | 
			
		||||
                            # second the audio
 | 
			
		||||
                            if formats_info[0].get('vcodec') == 'none':
 | 
			
		||||
                                self.report_error('The first format must '
 | 
			
		||||
                                    'contain the video, try using '
 | 
			
		||||
                                    '"-f %s+%s"' % (format_2, format_1))
 | 
			
		||||
                                return
 | 
			
		||||
                            selected_format = {
 | 
			
		||||
                                'requested_formats': formats_info,
 | 
			
		||||
                                'format': rf,
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user